chamikaramj commented on code in PR #22462:
URL: https://github.com/apache/beam/pull/22462#discussion_r931387785
##########
sdks/java/extensions/python/src/main/resources/org/apache/beam/sdk/extensions/python/bootstrap_beam_venv.py:
##########
@@ -92,6 +92,17 @@ def maybe_strict_version(s):
if not os.path.exists(venv_python):
try:
subprocess.run([executable, '-m', 'venv', venv_dir], check=True)
+
+ # Upgrading pip and setuptools for the virtual environment.
Review Comment:
I think we cache the virtual environment so the code will not break as long
as the cache is available ?
We also recommend such upgrades when installing Beam in the Quickstart guide.
##########
sdks/java/extensions/python/src/main/resources/org/apache/beam/sdk/extensions/python/bootstrap_beam_venv.py:
##########
@@ -92,6 +92,17 @@ def maybe_strict_version(s):
if not os.path.exists(venv_python):
try:
subprocess.run([executable, '-m', 'venv', venv_dir], check=True)
+
+ # Upgrading pip and setuptools for the virtual environment.
+ subprocess.run([
+ venv_python, '-m', 'pip', 'install', '--upgrade', 'pip'
Review Comment:
I didn't notice a considerable increase in the launch time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
