ihji commented on code in PR #22462:
URL: https://github.com/apache/beam/pull/22462#discussion_r931469314


##########
sdks/java/extensions/python/src/main/resources/org/apache/beam/sdk/extensions/python/bootstrap_beam_venv.py:
##########
@@ -92,6 +92,17 @@ def maybe_strict_version(s):
     if not os.path.exists(venv_python):
         try:
             subprocess.run([executable, '-m', 'venv', venv_dir], check=True)
+
+            # Upgrading pip and setuptools for the virtual environment.

Review Comment:
   Yeah, caching seems fine (possibly be confusing in certain cases since the 
same version works for some people and doesn't work for the others depending on 
the time they first launch the service).
   
   In the long term, I think we could dockerize default expansion services 
(like we release the SDK containers for each SDKs for each SDK version).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to