ryanthompson591 commented on code in PR #22626: URL: https://github.com/apache/beam/pull/22626#discussion_r944724877
########## model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml: ########## @@ -455,6 +455,17 @@ examples: --- +coder: + urn: "beam:coder:row:v1" Review Comment: can you double check this is not a typo. For example with double this is: beam:coder:double:v1 I would suspect this should be beam:coder:float:v1 ########## model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml: ########## @@ -455,6 +455,17 @@ examples: --- +coder: + urn: "beam:coder:row:v1" + # f_float: float32 Review Comment: why f_float instead of float or float32? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
