TheNeuralBit commented on code in PR #22626: URL: https://github.com/apache/beam/pull/22626#discussion_r944795282
########## model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml: ########## @@ -455,6 +455,17 @@ examples: --- +coder: + urn: "beam:coder:row:v1" Review Comment: This is a reference to row coder: https://github.com/apache/beam/blob/3173b503beaf30c4d32a4a39c709fd81e8161907/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto#L1062 Row Coder is a complex coder that is parameterized by a Beam Schema. It encodes different types of values by deferring to other coders, like `beam:coder:double:v1` for DOUBLE ########## model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml: ########## @@ -455,6 +455,17 @@ examples: --- +coder: + urn: "beam:coder:row:v1" + # f_float: float32 Review Comment: f_float here is the name of a field in the schema. We could call it "float" or "float32" instead, but it's not that important. I just followed the f_<type> convention used elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
