lukecwik commented on code in PR #22924:
URL: https://github.com/apache/beam/pull/22924#discussion_r962019019
##########
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py:
##########
@@ -653,7 +651,8 @@ def __init__(self,
from apache_beam.transforms.environments import
EmbeddedPythonGrpcEnvironment
config =
EmbeddedPythonGrpcEnvironment.parse_config(payload.decode('utf-8'))
- self._state_cache_size = config.get('state_cache_size') or STATE_CACHE_SIZE
+ self._state_cache_size = (
+ config.get('state_cache_size') or STATE_CACHE_SIZE_MB) << 20
Review Comment:
This is from an experiment. The idea is that we will get rid of this option
and migrate to the caching options that Java has:
https://github.com/apache/beam/blob/4a8947e3cd8aa0a1f2ead7a471bbf7040f56e691/sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java#L132
https://github.com/apache/beam/blob/4a8947e3cd8aa0a1f2ead7a471bbf7040f56e691/sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java#L150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
