lukecwik commented on code in PR #22924:
URL: https://github.com/apache/beam/pull/22924#discussion_r962022811
##########
sdks/python/apache_beam/runners/worker/statecache_test.py:
##########
@@ -21,209 +21,157 @@
import logging
import unittest
-from apache_beam.metrics import monitoring_infos
+from apache_beam.runners.worker.statecache import CacheAware
from apache_beam.runners.worker.statecache import StateCache
+from apache_beam.runners.worker.statecache import WeightedValue
class StateCacheTest(unittest.TestCase):
def test_empty_cache_get(self):
- cache = self.get_cache(5)
+ cache = StateCache(5 << 20)
self.assertEqual(cache.get("key", 'cache_token'), None)
with self.assertRaises(Exception):
# Invalid cache token provided
self.assertEqual(cache.get("key", None), None)
- self.verify_metrics(
- cache,
- {
- 'get': 1,
- 'put': 0,
- 'miss': 1,
- 'hit': 0,
- 'clear': 0,
- 'evict': 0,
- 'size': 0,
- 'capacity': 5
- })
+ self.assertEqual(
+ cache.describe_stats(),
+ 'used/max 0/5 MB, hit 0.00%, lookups 1, evictions 0')
def test_put_get(self):
- cache = self.get_cache(5)
- cache.put("key", "cache_token", "value")
+ cache = StateCache(5 << 20)
+ cache.put("key", "cache_token", WeightedValue("value", 1 << 20))
self.assertEqual(cache.size(), 1)
self.assertEqual(cache.get("key", "cache_token"), "value")
self.assertEqual(cache.get("key", "cache_token2"), None)
with self.assertRaises(Exception):
self.assertEqual(cache.get("key", None), None)
- self.verify_metrics(
- cache,
- {
- 'get': 2,
- 'put': 1,
- 'miss': 1,
- 'hit': 1,
- 'clear': 0,
- 'evict': 0,
- 'size': 1,
- 'capacity': 5
- })
+ self.assertEqual(
+ cache.describe_stats(),
+ 'used/max 1/5 MB, hit 50.00%, lookups 2, evictions 0')
def test_clear(self):
- cache = self.get_cache(5)
+ cache = StateCache(5 << 20)
cache.clear("new-key", "cache_token")
- cache.put("key", "cache_token", ["value"])
+ cache.put("key", "cache_token", WeightedValue(["value"], 1 << 20))
Review Comment:
We specifically test the `get_deep_size` version with
`test_default_sized_put` and use `WeigtedValue` for the other tests to get
consistent results in the test which aren't reliant on Python's GC and size
estimation implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
