mosche commented on code in PR #23041:
URL: https://github.com/apache/beam/pull/23041#discussion_r964637840
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1411,8 +1413,13 @@ class BeamModulePlugin implements Plugin<Project> {
project.tasks.register("jmh", JavaExec) {
dependsOn project.classes
- mainClass = "org.openjdk.jmh.Main"
+ mainClass = "org.apache.beam.sdk.testutils.jmh.Main"
classpath = project.sourceSets.main.runtimeClasspath
+
+ environment([
+ 'INFLUXDB_MEASUREMENT': 'java_jmh_' + (getPath().split(':') - ['',
'sdks', 'java', 'jmh']).join('_')
Review Comment:
Happy to discuss this... as long as benchmarks are in core (or core related
modules) only I wouldn't consider this to be important. But assuming there
could be benchmarks on IOs as well, it would be convenient to scope them in a
more granular way. That makes it a bit easier to treat them differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
