lukecwik commented on code in PR #23041:
URL: https://github.com/apache/beam/pull/23041#discussion_r965059194
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1411,8 +1413,13 @@ class BeamModulePlugin implements Plugin<Project> {
project.tasks.register("jmh", JavaExec) {
dependsOn project.classes
- mainClass = "org.openjdk.jmh.Main"
+ mainClass = "org.apache.beam.sdk.testutils.jmh.Main"
classpath = project.sourceSets.main.runtimeClasspath
+
+ environment([
+ 'INFLUXDB_MEASUREMENT': 'java_jmh_' + (getPath().split(':') - ['',
'sdks', 'java', 'jmh']).join('_')
Review Comment:
I was under the impression that if the data we collect for a measurement is
the same then we should use a single measurement. For example we could have two
different types of JMH runs (throughput and sample time) which we would want to
store in a different measurement since they are collecting different data. In
our case we are using the JMH throughput mode run for all our benchmarks
currently so it would make sense to store it all in one measurement.
nit: note that folks may want to have benchmarks under `runners/` like
`runners/java-fn-execution` which could lead to a collision in measurement
names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
