TheNeuralBit commented on PR #23194: URL: https://github.com/apache/beam/pull/23194#issuecomment-1245842369
Very cool, thank you! I will take a detailed look in the next few days. First some high-level comments: - This currently isn't used anywhere, right? Any thoughts on how we would plumb this in? - I think it would be a good idea to exercise this with the integration tests in standard_coders.yaml. In a few cases we have multiple test values (e.g. here: https://github.com/apache/beam/blob/6f25fba3fea1f407c7a008c84709047b7a55be54/model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml#L357-L364). We could concatenate together the encoded representations and verify a batch decode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
