robertwb commented on PR #23194: URL: https://github.com/apache/beam/pull/23194#issuecomment-1245982201
On Tue, Sep 13, 2022 at 12:05 PM Brian Hulette ***@***.***> wrote: > Very cool, thank you! I will take a detailed look in the next few days. > First some high-level comments: > > - This currently isn't used anywhere, right? Any thoughts on how we > would plumb this in? > > Correct, this isn't used yet. I was thinking we could possibly add methods like "encode_batch" and "decode_batch" to the BatchConverters that would take a coder, whose default implementation would be to explode/encode (or vice versa) but could be overridden. The input/output ports would take advantage of this. > > - I think it would be a good idea to exercise this with the > integration tests in standard_coders.yaml. In a few cases we have multiple > test values (e.g. here: > https://github.com/apache/beam/blob/6f25fba3fea1f407c7a008c84709047b7a55be54/model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml#L357-L364). > We could concatenate together the encoded representations and verify a > batch decode. > > Good idea. Will do. > > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/23194#issuecomment-1245842369>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADWVAP7DOB3LYJSMJZOBQLV6DF6DANCNFSM6AAAAAAQK2LWFU> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
