lostluck commented on code in PR #23222:
URL: https://github.com/apache/beam/pull/23222#discussion_r970150570
##########
sdks/go/pkg/beam/core/runtime/exec/coder.go:
##########
@@ -1208,3 +1213,91 @@ func DecodeWindowedValueHeader(dec WindowDecoder, r
io.Reader) ([]typex.Window,
return ws, t, pn, nil
}
+
+// EncodeTimer encodes a typex.TimerMap into a byte stream.
+func EncodeTimer(elm ElementEncoder, tm typex.TimerMap, w io.Writer) error {
Review Comment:
Does this need to be exported?
Can we move it, or parts of it into the graph/coder package along with the
other concrete coder implementations (I suspect it will probably live here with
the window header for the same reasons though...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
