riteshghorse commented on code in PR #23222:
URL: https://github.com/apache/beam/pull/23222#discussion_r970896843
##########
sdks/go/pkg/beam/core/runtime/exec/coder.go:
##########
@@ -1208,3 +1213,91 @@ func DecodeWindowedValueHeader(dec WindowDecoder, r
io.Reader) ([]typex.Window,
return ws, t, pn, nil
}
+
+// EncodeTimer encodes a typex.TimerMap into a byte stream.
+func EncodeTimer(elm ElementEncoder, tm typex.TimerMap, w io.Writer) error {
Review Comment:
It doesn't need to. I had both of these encode and decode in `graph/coder/`
but it creates weird import cycle. To separate some parts, I think Encoding
will work fine but we need to pass in exec.ElementDecoder and
exec.WindowDecoder to Decode which creates weird import cycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
