rvballada commented on code in PR #22932:
URL: https://github.com/apache/beam/pull/22932#discussion_r977555690
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -463,23 +469,24 @@ public Coder<T> getOutputCoder() {
static class UnboundedJmsReader<T> extends UnboundedReader<T> {
private UnboundedJmsSource<T> source;
- private JmsCheckpointMark checkpointMark;
private Connection connection;
private Session session;
private MessageConsumer consumer;
private AutoScaler autoScaler;
private T currentMessage;
+ private Message currentJmsMessage;
private Instant currentTimestamp;
- public UnboundedJmsReader(UnboundedJmsSource<T> source, JmsCheckpointMark
checkpointMark) {
+ Set<Message> messagesToAck;
Review Comment:
Hello,
The messagesToAck set is cleared every time we checkpoint (in the
getCheckpointmark method).
Before that the same set was maintained in the JmsCheckpointmark. I don't
think maintaining this is memory intensive.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
