rvballada commented on code in PR #22932:
URL: https://github.com/apache/beam/pull/22932#discussion_r984697468
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -364,6 +381,10 @@ public Read<T> withAutoScaler(AutoScaler autoScaler) {
return builder().setAutoScaler(autoScaler).build();
}
+ public Read<T> withCloseTimeout(long closeTimeout) {
Review Comment:
Yes we want to want to wait before closing the session, and then the
connection. The closing of the session will indicate to the broker that all
unacknowledged messages must be kept into the queue to be redelivered.
Don't know which is best, withSessionConnectionCloseTimeou,
withSessionCloseTimeout....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
