pcostell commented on code in PR #23322:
URL: https://github.com/apache/beam/pull/23322#discussion_r982422736
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreOptions.java:
##########
@@ -45,4 +46,15 @@ public interface FirestoreOptions extends PipelineOptions {
* @see
com.google.cloud.firestore.FirestoreOptions.Builder#setEmulatorHost(java.lang.String)
*/
void setEmulatorHost(String host);
+
+ /**
+ * The Firestore database ID to connect to. Note: named database is
currently an internal feature
+ * in Firestore. Do not set this to anything other than "(default)".
+ */
+ @Description("Firestore database ID")
+ @Default.String("(default)")
+ String getFirestoreDb();
Review Comment:
not sure on the consistency across beam, but given this is in the
FirestoreOptions already, I would align this closer to the Firestore API naming
convention: getDatabaseId / setDatabaseId (maybe getDatabase/setDatabase, but
the Id suffix aligns better with our API style)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
