steveniemitz commented on code in PR #22718:
URL: https://github.com/apache/beam/pull/22718#discussion_r983721125
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -573,6 +576,29 @@ public static TypedRead<TableRow>
readTableRowsWithSchema() {
BigQueryUtils.tableRowFromBeamRow());
}
+ @VisibleForTesting
+ static class GenericDatumTransformer<T> extends GenericDatumReader<T> {
Review Comment:
can this extend `DatumReader` rather than `GenericDatumReader`? You're not
actually using any of the GenericDatumReader functionality here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
