steveniemitz commented on code in PR #22718:
URL: https://github.com/apache/beam/pull/22718#discussion_r983723130
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -598,7 +624,44 @@ public static <T> TypedRead<T>
read(SerializableFunction<SchemaAndRecord, T> par
.setValidate(true)
.setWithTemplateCompatibility(false)
.setBigQueryServices(new BigQueryServicesImpl())
- .setParseFn(parseFn)
+ .setDatumReaderFactory(
+ (SerializableFunction<TableSchema,
AvroSource.DatumReaderFactory<T>>)
+ input ->
+ (AvroSource.DatumReaderFactory<T>)
+ (writer, reader) ->
+ new GenericDatumTransformer<>(parseFn, input,
writer, reader))
+ .setParseFn(
+ parseFn) // TODO: Remove setParseFn once
https://github.com/apache/beam/issues/21076 is fixed.
Review Comment:
you'll want to run spotlessJavaApply on everything here, the precommit is
complaining too about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
