lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447375156
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java
##########
@@ -99,6 +100,10 @@
*/
public abstract void checkDone() throws IllegalStateException;
+ public boolean isBounded() throws NotImplementedException {
Review comment:
Your right in using PCollection.IsBounded would be weird unless we also
say something along the lines that processing the entire restriction would
produce a bounded/unbounded PCollection then it would make sense.
The purpose of not using a boolean on PCollection was to make it clear
whether something was bounded or unbounded. Boolean values also require the
person to remember what the contract of the method is.
Alternatively, we can define an enum in RestrictionTracker similar to what
we do in PCollection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
