lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r448104124
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -488,90 +492,32 @@
|| (doFnSignature.getSize() != null &&
doFnSignature.getSize().observesWindow())
|| !sideInputMapping.isEmpty()) {
mainInputConsumer =
this::processElementForWindowObservingSplitRestriction;
- // OutputT == RestrictionT
this.processContext =
- new WindowObservingProcessBundleContext() {
- @Override
- public void outputWithTimestamp(OutputT output, Instant
timestamp) {
- double size =
- doFnInvoker.invokeGetSize(
- new DelegatingArgumentProvider<InputT, OutputT>(
- this,
-
PTransformTranslation.SPLITTABLE_SPLIT_AND_SIZE_RESTRICTIONS_URN
- + "/GetSize") {
- @Override
- public Object restriction() {
- return output;
- }
-
- @Override
- public Instant timestamp(DoFn<InputT, OutputT>
doFn) {
- return timestamp;
- }
-
- @Override
- public RestrictionTracker<?, ?>
restrictionTracker() {
- return doFnInvoker.invokeNewTracker(this);
- }
- });
-
- outputTo(
- mainOutputConsumers,
- (WindowedValue<OutputT>)
- WindowedValue.of(
- KV.of(
- KV.of(
- currentElement.getValue(),
- KV.of(output,
currentWatermarkEstimatorState)),
- size),
- timestamp,
- currentWindow,
- currentElement.getPane()));
- }
- };
+ new SizedRestrictionWindowObservingProcessBundleContext(
+
PTransformTranslation.SPLITTABLE_SPLIT_AND_SIZE_RESTRICTIONS_URN);
+
} else {
mainInputConsumer = this::processElementForSplitRestriction;
- // OutputT == RestrictionT
this.processContext =
- new NonWindowObservingProcessBundleContext() {
- @Override
- public void outputWithTimestamp(OutputT output, Instant
timestamp) {
- double size =
- doFnInvoker.invokeGetSize(
- new DelegatingArgumentProvider<InputT, OutputT>(
- this,
-
PTransformTranslation.SPLITTABLE_SPLIT_AND_SIZE_RESTRICTIONS_URN
- + "/GetSize") {
- @Override
- public Object restriction() {
- return output;
- }
-
- @Override
- public Instant timestamp(DoFn<InputT, OutputT>
doFn) {
- return timestamp;
- }
-
- @Override
- public RestrictionTracker<?, ?>
restrictionTracker() {
- return doFnInvoker.invokeNewTracker(this);
- }
- });
-
- outputTo(
- mainOutputConsumers,
- (WindowedValue<OutputT>)
- WindowedValue.of(
- KV.of(
- KV.of(
- currentElement.getValue(),
- KV.of(output,
currentWatermarkEstimatorState)),
- size),
- timestamp,
- currentElement.getWindows(),
- currentElement.getPane()));
- }
- };
+ new SizedRestrictionNonWindowObservingProcessBundleContext(
+
PTransformTranslation.SPLITTABLE_SPLIT_AND_SIZE_RESTRICTIONS_URN);
+ }
+ break;
+ case PTransformTranslation.SPLITTABLE_TRUNCATE_SIZED_RESTRICTION_URN:
Review comment:
Must propagate progress/split calls to the downstream operator otherwise
checkpointing will not work causing pipelines to produce to much output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
