tvalentyn commented on code in PR #23070:
URL: https://github.com/apache/beam/pull/23070#discussion_r988316445
##########
sdks/python/apache_beam/io/gcp/bigquery_schema_tools.py:
##########
@@ -38,8 +39,10 @@
"STRING": str,
"INTEGER": np.int64,
"FLOAT64": np.float64,
+ "FLOAT": np.float64,
"BOOLEAN": bool,
"BYTES": bytes,
+ "TIMESTAMP": apache_beam.utils.timestamp.Timestamp.from_utc_datetime
Review Comment:
cc: @Abacn @TheNeuralBit who worked on
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/typehints/schemas.py#L36-L37
Folks, do you know what (if any) aspects we need to take care of for this
change to correctly work with schemas & xlang?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
