tvalentyn commented on code in PR #23070:
URL: https://github.com/apache/beam/pull/23070#discussion_r988341825
##########
sdks/python/apache_beam/io/gcp/bigquery_schema_tools.py:
##########
@@ -38,8 +39,10 @@
"STRING": str,
"INTEGER": np.int64,
"FLOAT64": np.float64,
+ "FLOAT": np.float64,
"BOOLEAN": bool,
"BYTES": bytes,
+ "TIMESTAMP": apache_beam.utils.timestamp.Timestamp.from_utc_datetime
Review Comment:
Thanks. It seems that we should drop `.from_utc_datetime` as that is a
method, which returns the Timestamp.
Any concerns with that @svetakvsundhar ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
