damccorm commented on PR #23642: URL: https://github.com/apache/beam/pull/23642#issuecomment-1279243259
> This is kind of what I'm thinking, the numpy handler is where I want it but I don't love the pandas impl also handling splits the way it does. Fortunately it's also marked as experimental so we can change that as needed. This generally looks right to me. I would ask that before taking this much further you update the design doc to reflect this approach (tossing in this example would be great!). This approach will get a LGTM from me (and I expect others), but I'd like to formalize consensus. Thanks for all the haggling/back and forth you've done to make sure we're building the right thing here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
