Abacn commented on code in PR #23668:
URL: https://github.com/apache/beam/pull/23668#discussion_r997228021
##########
sdks/python/apache_beam/runners/worker/sdk_worker_main_test.py:
##########
@@ -174,26 +185,23 @@ def test__set_log_level_overrides(self):
)
]
for case, expected in test_cases:
- options_dict = {'sdk_harness_log_level_overrides': case}
- sdk_worker_main._set_log_level_overrides(options_dict)
+ overrides = self._overrides_case_to_option_dict(case)
+ sdk_worker_main._set_log_level_overrides(overrides)
for name, level in expected.items():
self.assertEqual(logging.getLogger(name).getEffectiveLevel(), level)
def test__set_log_level_overrides_error(self):
test_cases = [
- ({
Review Comment:
Now illegal json command as argument fails as early as pipeline option
parsing. So that these test cases for error handling changed to valid json but
unexpected arrays or invalid levels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
