Abacn commented on code in PR #23668:
URL: https://github.com/apache/beam/pull/23668#discussion_r997478446
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java:
##########
@@ -290,18 +303,24 @@ public SdkHarnessLogLevelOverrides
addOverrideForName(String name, LogLevel logL
* name}, or fully qualified Java {@link Package#getName() package name},
or custom logger name.
* The {@code LogLevel} represents the log level and must be one of {@link
LogLevel}.
*/
- @JsonCreator
+ @JsonCreator(mode = JsonCreator.Mode.DELEGATING)
Review Comment:
when DELEGATING not specified, the default AUTO reduced to
[PROPERTIES](https://fasterxml.github.io/jackson-annotations/javadoc/2.13/com/fasterxml/jackson/annotation/JsonCreator.Mode.html)
mode, then it expects the argument has names of the json load keys (like
expanding **kwargs in Python). This does not work. Explicitely use "DELEGATING"
then match the Map argument for this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
