lostluck commented on code in PR #23641:
URL: https://github.com/apache/beam/pull/23641#discussion_r997569689
##########
sdks/go/pkg/beam/core/runtime/graphx/translate.go:
##########
@@ -682,6 +683,19 @@ func (m *marshaller) expandCrossLanguage(namedEdge
NamedEdge) (string, error) {
EnvironmentId: m.addDefaultEnv(),
}
+ // Add the coders for output types in the marshaller even if expanded
is nil
+ // to set the output coder request field in expansion request for
python external transforms.
+ names := strings.Split(spec.Urn, ":")
+ if len(names) > 2 && names[2] == "python" {
Review Comment:
Does anything fail when we always provide output codings to the expansion
services?
Ideally if Java doesn't use them, they should be ignored, and all the
expansion outputs should be known Beam coders (rather than Java or Python or Go
specific).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
