riteshghorse commented on code in PR #23641:
URL: https://github.com/apache/beam/pull/23641#discussion_r998319587
##########
sdks/go/pkg/beam/core/runtime/graphx/translate.go:
##########
@@ -682,6 +683,19 @@ func (m *marshaller) expandCrossLanguage(namedEdge
NamedEdge) (string, error) {
EnvironmentId: m.addDefaultEnv(),
}
+ // Add the coders for output types in the marshaller even if expanded
is nil
+ // to set the output coder request field in expansion request for
python external transforms.
+ names := strings.Split(spec.Urn, ":")
+ if len(names) > 2 && names[2] == "python" {
Review Comment:
That was with an earlier approach though which I made it simpler later in
latest commit. Testing it locally for commit
[f69475d](https://github.com/apache/beam/pull/23641/commits/f69475dc51aa4c9d4c43c0e089db5d8e254a5250)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
