arne-alex commented on code in PR #23333:
URL: https://github.com/apache/beam/pull/23333#discussion_r997815908
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillStateReader.java:
##########
@@ -195,6 +196,7 @@ public ValuesAndContPosition(List<T> values, @Nullable
ContinuationT continuatio
private final ByteString key;
private final long shardingKey;
private final long workToken;
+ private final Supplier<AutoCloseable> readWrapperSupplier;
Review Comment:
Done
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillStateReader.java:
##########
@@ -472,7 +485,13 @@ public void startBatchAndBlock() {
}
Windmill.KeyedGetDataRequest request = createRequest(toFetch);
- Windmill.KeyedGetDataResponse response =
server.getStateData(computation, request);
+ Windmill.KeyedGetDataResponse response;
+ try (AutoCloseable readWrapper =
+ readWrapperSupplier == null ? null : readWrapperSupplier.get()) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
