arne-alex commented on code in PR #23333:
URL: https://github.com/apache/beam/pull/23333#discussion_r1004975009
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -1871,16 +1946,17 @@ private void schedulePeriodicGlobalConfigRequests() {
LOG.info("windmillServerStub is now ready");
// Now start a thread that periodically refreshes the windmill service
endpoint.
- globalConfigRefreshTimer = new Timer("GlobalConfigRefreshTimer");
- globalConfigRefreshTimer.schedule(
- new TimerTask() {
+ globalConfigRefreshTimer = executorSupplier.get();
+ globalConfigRefreshTimer.scheduleWithFixedDelay(
+ new Runnable() {
Review Comment:
Done
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -857,32 +871,34 @@ public void run() {
}
},
options.getActiveWorkRefreshPeriodMillis(),
- options.getActiveWorkRefreshPeriodMillis());
+ options.getActiveWorkRefreshPeriodMillis(),
+ TimeUnit.MILLISECONDS);
}
if (windmillServiceEnabled && options.getStuckCommitDurationMillis() > 0) {
int periodMillis = Math.max(options.getStuckCommitDurationMillis() / 10,
100);
- refreshWorkTimer.schedule(
- new TimerTask() {
+ refreshWorkTimer.scheduleWithFixedDelay(
+ new Runnable() {
@Override
public void run() {
invalidateStuckCommits();
}
},
periodMillis,
- periodMillis);
+ periodMillis,
+ TimeUnit.MILLISECONDS);
}
if (options.getPeriodicStatusPageOutputDirectory() != null) {
- statusPageTimer = new Timer("DumpStatusPages");
- statusPageTimer.schedule(
- new TimerTask() {
+ statusPageTimer = executorSupplier.get();
+ statusPageTimer.scheduleWithFixedDelay(
+ new Runnable() {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
