robertwb commented on a change in pull request #12133:
URL: https://github.com/apache/beam/pull/12133#discussion_r448527930
##########
File path: sdks/python/apache_beam/transforms/sql.py
##########
@@ -67,10 +66,9 @@ class SqlTransform(ExternalTransform):
"""
URN = 'beam:external:java:sql:v1'
- def __init__(self, query, dialect=None):
+ def __init__(self, query, dialect=None, expansion_service=None):
super(SqlTransform, self).__init__(
self.URN,
NamedTupleBasedPayloadBuilder(
SqlTransformSchema(query=query, dialect=dialect)),
- BeamJarExpansionService(
- ':sdks:java:extensions:sql:expansion-service:shadowJar'))
+ expansion_service=expansion_service)
Review comment:
Note that you can use `JavaJarServer.beam_services()` (automatically
populated by the `--beam_services` flag) to specify an alternative jar or live
expansion service for any beam target.
##########
File path: sdks/python/apache_beam/transforms/sql.py
##########
@@ -67,10 +66,9 @@ class SqlTransform(ExternalTransform):
"""
URN = 'beam:external:java:sql:v1'
- def __init__(self, query, dialect=None):
+ def __init__(self, query, dialect=None, expansion_service=None):
super(SqlTransform, self).__init__(
self.URN,
NamedTupleBasedPayloadBuilder(
SqlTransformSchema(query=query, dialect=dialect)),
- BeamJarExpansionService(
- ':sdks:java:extensions:sql:expansion-service:shadowJar'))
+ expansion_service=expansion_service)
Review comment:
We definitely want to accept an expansion service as an argument, but
the default should remain
`BeamJarExpansionService(':sdks:java:extensions:sql:expansion-service:shadowJar')`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
