robertwb commented on a change in pull request #12133:
URL: https://github.com/apache/beam/pull/12133#discussion_r450478632
##########
File path: sdks/python/apache_beam/transforms/sql.py
##########
@@ -67,10 +66,9 @@ class SqlTransform(ExternalTransform):
"""
URN = 'beam:external:java:sql:v1'
- def __init__(self, query, dialect=None):
+ def __init__(self, query, dialect=None, expansion_service=None):
super(SqlTransform, self).__init__(
self.URN,
NamedTupleBasedPayloadBuilder(
SqlTransformSchema(query=query, dialect=dialect)),
- BeamJarExpansionService(
- ':sdks:java:extensions:sql:expansion-service:shadowJar'))
+ expansion_service=expansion_service)
Review comment:
+1, a wider discussion about expansion service discovery and bundling
would be very good to have on the mailing list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
