amaliujia commented on a change in pull request #12153:
URL: https://github.com/apache/beam/pull/12153#discussion_r448618515
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##########
@@ -920,8 +946,23 @@ private RexNode convertResolvedFunctionCall(
}
for (ResolvedExpr expr : functionCall.getArgumentList()) {
- operands.add(convertRexNodeFromResolvedExpr(expr, columnList,
fieldList));
+ operands.add(
+ convertRexNodeFromResolvedExpr(expr, columnList, fieldList,
outerFunctionArguments));
+ }
+ } else if (funGroup.equals(USER_DEFINED_FUNCTIONS)) {
Review comment:
I see. For Java UDF (without a nested call), it might not go through the
process to convert every of its arguments. But for nested call cases,
especially with builtin functions, it could go through this process.
We can keep current implementation in this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
