lukecwik commented on code in PR #23882:
URL: https://github.com/apache/beam/pull/23882#discussion_r1009936216
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -1175,6 +1183,12 @@ private Progress
getProgressFromWindowObservingTruncate(double elementCompleted)
@VisibleForTesting
static Progress scaleProgress(Progress progress, int currentWindowIndex, int
stopWindowIndex) {
Review Comment:
`Progress SplittableFnDataReceiver.getProgress()` should check to see if the
current window is null just like `getProgressFromWindowObservingTruncate` does
otherwise the checkArgument would fail.
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -1175,6 +1183,12 @@ private Progress
getProgressFromWindowObservingTruncate(double elementCompleted)
@VisibleForTesting
static Progress scaleProgress(Progress progress, int currentWindowIndex, int
stopWindowIndex) {
Review Comment:
`Progress SplittableFnDataReceiver.getProgress()` should check to see if the
current window is null just like `getProgressFromWindowObservingTruncate` does
otherwise the checkArgument could fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
