[GitHub] [beam] scwhittle commented on a diff in pull request #23882: Enforce splitting invariants by ensuring split state is reset in the same synchronized block as window index increments.

Wed, 02 Nov 2022 04:48:31 -0700 


scwhittle commented on code in PR #23882:
URL: https://github.com/apache/beam/pull/23882#discussion_r1011628810


##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -999,14 +1022,7 @@ public void onClaimFailed(PositionT position) {}
         }
       }
     } finally {

Review Comment:
   Note that this finally structure is used throughout to reset after 
processing.  If you do think it should be done, should I update the other 
places in this file too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to