apilloud commented on code in PR #24013:
URL: https://github.com/apache/beam/pull/24013#discussion_r1015872459
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/util/RowJsonTest.java:
##########
@@ -132,14 +132,10 @@ private static Object[] makeFlatRowTestCase() {
private static Object[] makeLogicalTypeTestCase() {
Schema schema =
- Schema.builder()
- .addLogicalTypeField(
- "f_passThroughString",
- new PassThroughLogicalType<String>(
- "SqlCharType", FieldType.STRING, "", FieldType.STRING)
{})
- .build();
+ Schema.builder().addLogicalTypeField("f_passThroughString",
FixedString.of(10)).build();
Review Comment:
Why `FixedString.of(10)`? Does the padding behavior need to be tested here?
(The common use case is in a SQL statement with string constants, which are
allocated at the correct size and not padded. I'm not sure there is another way
to get char type today.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
