Abacn commented on code in PR #24013:
URL: https://github.com/apache/beam/pull/24013#discussion_r1015936935
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/CalciteUtils.java:
##########
@@ -109,7 +99,7 @@ public static boolean isStringType(FieldType fieldType) {
public static final FieldType BOOLEAN = FieldType.BOOLEAN;
public static final FieldType VARBINARY = FieldType.BYTES;
public static final FieldType VARCHAR = FieldType.STRING;
- public static final FieldType CHAR = FieldType.logicalType(new CharType());
+ public static final FieldType CHAR = FieldType.STRING;
Review Comment:
Hi @apilloud, do you think it suffices to map CHAR to String as we did for
mapping BINARY to bytes, or we should also implement #24019 in this PR. Is
there any breaking change if treat CHAR as String in Beam?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
