creste commented on code in PR #24212: URL: https://github.com/apache/beam/pull/24212#discussion_r1024607628
########## sdks/python/apache_beam/io/azure/integration_test/create_certificate.sh: ########## @@ -0,0 +1,2 @@ +#!/bin/bash Review Comment: I deleted `create_certificate.sh` and moved the cert creation code to `azure_integration_test.sh`, then I deleted `cert.pem` and `key.pem` to avoid the license header issues. Generating the certificate on every test run adds just a second or two to the total test time. I hope that solution is acceptable, but happy to change it if not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
