Abacn commented on PR #24212: URL: https://github.com/apache/beam/pull/24212#issuecomment-1317852713
> > ``` > > # Run from root beam repo dir > > pip install yapf==0.29.0 > > git diff master --name-only | grep "\.py$" | xargs yapf --in-place > > ``` > > Thank you for the tip! I ran those commands and fixed all linting errors in the files I modified. One exception is `sdks/python/setup.py`, which appears to have many style issues outside of my changes. I didn't fix those. > > The PythonLint Jenkins job is [failing](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Commit/16635/console) with linting errors outside of the code I modified: > > > 18:47:35 ************* Module apache_beam.typehints.batch > > 18:47:35 apache_beam/typehints/batch.py:32:0: W0611: Unused List imported from typing (unused-import) > > 18:47:35 ************* Module apache_beam.dataframe.frames > > 18:47:35 apache_beam/dataframe/frames.py:679:53: I1101: Module 'pandas._libs.lib' has no 'no_default' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member) > > I'm not sure how to proceed. The remaining linting error is ``` 18:47:35 ************* Module apache_beam.typehints.batch 18:47:35 apache_beam/typehints/batch.py:32:0: W0611: Unused List imported from typing (unused-import) ``` not relevant to the change. It was introduced in #24022 but somehow not detected by linter. Never mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
