alexeyinkin commented on code in PR #24283:
URL: https://github.com/apache/beam/pull/24283#discussion_r1034478976
##########
playground/frontend/playground_components/lib/src/models/example.dart:
##########
@@ -49,8 +53,11 @@ class Example extends ExampleBase {
required this.logs,
required this.outputs,
required this.source,
+ ExampleLoadingDescriptor? descriptor,
this.graph,
- }) : super(
+ }) : descriptor =
+ descriptor ?? StandardExampleLoadingDescriptor(path: example.path),
Review Comment:
Second thoughts, it's better to not put the descriptor into the `Example`
and just do `SnippetEditingController.setExample(example, descriptor:
descriptor)`
This is better because from the domain POV the descriptor is not a part of
the example. And this simplifies a lot of things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
