Malarg commented on code in PR #24283:
URL: https://github.com/apache/beam/pull/24283#discussion_r1035670657
##########
playground/frontend/playground_components/lib/src/models/example.dart:
##########
@@ -49,8 +53,11 @@ class Example extends ExampleBase {
required this.logs,
required this.outputs,
required this.source,
+ ExampleLoadingDescriptor? descriptor,
this.graph,
- }) : super(
+ }) : descriptor =
+ descriptor ?? StandardExampleLoadingDescriptor(path: example.path),
Review Comment:
fixed
##########
playground/frontend/playground_components/lib/src/models/example_loading_descriptors/example_loading_descriptor.dart:
##########
@@ -28,4 +29,6 @@ abstract class ExampleLoadingDescriptor with EquatableMixin {
final ExampleViewOptions viewOptions;
Map<String, dynamic> toJson() => throw UnimplementedError();
+
+ bool get canBePassedByUrl => this is! ContentExampleLoadingDescriptor;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
