Abacn commented on code in PR #24274:
URL: https://github.com/apache/beam/pull/24274#discussion_r1036452165
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java:
##########
@@ -265,6 +266,7 @@ public abstract static class Builder {
.put(SqlTypes.DATETIME.getIdentifier(), StandardSQLTypeName.DATETIME)
.put("SqlTimeWithLocalTzType", StandardSQLTypeName.TIME)
.put("Enum", StandardSQLTypeName.STRING)
+ .put(MicrosInstant.IDENTIFIER, StandardSQLTypeName.TIMESTAMP)
Review Comment:
Is there a test verifying that this logical type is supported? MicrosInstant
is used for `java.time.Instant` (saying, testing write `java.time.Instant` to
BigQuery)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
