prodriguezdefino commented on code in PR #24274:
URL: https://github.com/apache/beam/pull/24274#discussion_r1037463827
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -3165,6 +3156,26 @@ private <DestinationT> WriteResult continueExpandTyped(
storageApiDynamicDestinations =
new StorageApiDynamicDestinationsBeamRow<>(
dynamicDestinations, elementSchema, elementToRowFunction);
+ } else if (getAvroRowWriterFactory() != null) {
Review Comment:
> Please add a writeGenericRecords() method so users don't have to deal with
the avro format function.
Done.
>AFAICT from inspection, the AvroWriterFactory is a bit broken if side
inputs are used for schemas. Do we have a test for this?
You mean when the TableSchema is provided as a PCollectionView? If so I can
add a test for that.
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -3165,6 +3156,26 @@ private <DestinationT> WriteResult continueExpandTyped(
storageApiDynamicDestinations =
new StorageApiDynamicDestinationsBeamRow<>(
dynamicDestinations, elementSchema, elementToRowFunction);
+ } else if (getAvroRowWriterFactory() != null) {
Review Comment:
> Please add a writeGenericRecords() method so users don't have to deal with
the avro format function.
Done.
>AFAICT from inspection, the AvroWriterFactory is a bit broken if side
inputs are used for schemas. Do we have a test for this?
You mean when the TableSchema is provided as a PCollectionView? If so I can
add a test for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
