eantyshev commented on code in PR #24459:
URL: https://github.com/apache/beam/pull/24459#discussion_r1043252703
##########
playground/infrastructure/datastore_client.py:
##########
@@ -83,54 +85,65 @@ def save_to_cloud_datastore(self, examples_from_rep:
List[Example], sdk: Sdk, or
examples_ids_before_updating = self._get_all_examples(sdk, origin)
# loop through every example to save them to the Cloud Datastore
Review Comment:
this huge chunk is only to remove transaction when updating examples:
datastore transactions are limited to 500 entities affected, here we have
possibly more.
https://cloud.google.com/datastore/docs/concepts/limits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
