eantyshev commented on code in PR #24459:
URL: https://github.com/apache/beam/pull/24459#discussion_r1044434677
##########
playground/backend/internal/db/mapper/precompiled_object_mapper_test.go:
##########
@@ -41,7 +41,11 @@ func TestPrecompiledObjectMapper_ToObjectInfo(t *testing.T) {
actualResult.ContextLine != 32 ||
len(actualResult.Categories) != 3 ||
actualResult.Type.String() != "PRECOMPILED_OBJECT_TYPE_EXAMPLE"
||
- actualResult.Sdk != pb.Sdk_SDK_JAVA {
+ actualResult.Sdk != pb.Sdk_SDK_JAVA ||
+ len(actualResult.Datasets) != 1 ||
+ actualResult.Datasets[0].DatasetPath != "MOCK_PATH_0" ||
+ actualResult.Datasets[0].Options["Topic"] != "MOCK_TOPIC" ||
+ actualResult.Datasets[0].Type !=
pb.EmulatorType_EMULATOR_TYPE_KAFKA {
t.Error("ToObjectInfo() unexpected result")
Review Comment:
++ I changed this for assert.Equal to show detailed diff
there're many more such places in this file though, couldn't fix it all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
