alexeyinkin commented on code in PR #24338:
URL: https://github.com/apache/beam/pull/24338#discussion_r1043283902
##########
playground/frontend/lib/modules/editor/components/share_dropdown/share_button.dart:
##########
@@ -18,16 +18,21 @@
import 'package:flutter/material.dart';
import 'package:flutter_gen/gen_l10n/app_localizations.dart';
-import 'package:playground/components/dropdown_button/dropdown_button.dart';
-import
'package:playground/modules/editor/components/share_dropdown/share_dropdown_body.dart';
import 'package:playground_components/playground_components.dart';
+import '../../../../components/dropdown_button/dropdown_button.dart';
+import 'share_dropdown_body.dart';
+
const _kShareDropdownHeight = 140.0;
const _kShareDropdownWidth = 460.0;
const _kButtonColorOpacity = 0.2;
class ShareButton extends StatelessWidget {
- const ShareButton({super.key});
+ final PlaygroundController playgroundController;
Review Comment:
I want to get rid of all consumers and providers. I will reconsider as soon
as they have compile-time guarantee of presence of a provider in the tree. :)
In the sharing widgets `PlaygroundController` is really passed around too
much, but that is because of poor separation between those widgets. We may want
to refactor those later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
