alexeyinkin commented on code in PR #24338:
URL: https://github.com/apache/beam/pull/24338#discussion_r1043285318
##########
playground/frontend/lib/modules/examples/components/example_list/example_list.dart:
##########
@@ -17,24 +17,27 @@
*/
import 'package:flutter/material.dart';
-import
'package:playground/modules/examples/components/examples_components.dart';
-import
'package:playground/pages/playground/states/example_selector_state.dart';
import 'package:playground_components/playground_components.dart';
import 'package:provider/provider.dart';
-class ExampleList extends StatelessWidget {
- final ScrollController controller;
- final AnimationController animationController;
- final OverlayEntry? dropdown;
+import
'../../../../pages/standalone_playground/notifiers/example_selector_state.dart';
+import '../examples_components.dart';
+
+class ExampleList extends StatefulWidget {
+ final VoidCallback onSelected;
final ExampleBase selectedExample;
const ExampleList({
- Key? key,
- required this.controller,
+ required this.onSelected,
required this.selectedExample,
- required this.animationController,
- required this.dropdown,
- }) : super(key: key);
+ });
+
+ @override
+ State<ExampleList> createState() => _ExampleListState();
+}
+
+class _ExampleListState extends State<ExampleList> {
+ final _scrollController = ScrollController();
@override
Widget build(BuildContext context) {
Review Comment:
Should be addressed in https://github.com/apache/beam/issues/24371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
