mzitnik commented on code in PR #24424:
URL: https://github.com/apache/beam/pull/24424#discussion_r1045093695
##########
sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/ClickHouseWriter.java:
##########
@@ -39,19 +41,19 @@ public class ClickHouseWriter {
private static final Instant EPOCH_INSTANT = new Instant(0L);
@SuppressWarnings("unchecked")
- static void writeNullableValue(
- ClickHouseRowBinaryStream stream, ColumnType columnType, Object value)
throws IOException {
+ static void writeNullableValue(ClickHouseOutputStream stream, ColumnType
columnType, Object value)
+ throws IOException {
if (value == null) {
- stream.markNextNullable(true);
+ BinaryStreamUtils.writeNull(stream);
} else {
- stream.markNextNullable(false);
+ BinaryStreamUtils.writeNonNull(stream);
writeValue(stream, columnType, value);
}
}
@SuppressWarnings("unchecked")
- static void writeValue(ClickHouseRowBinaryStream stream, ColumnType
columnType, Object value)
+ static void writeValue(ClickHouseOutputStream stream, ColumnType columnType,
Object value)
Review Comment:
It is the same logic and i have only changed the API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
