mzitnik commented on code in PR #24424:
URL: https://github.com/apache/beam/pull/24424#discussion_r1045233513
##########
sdks/java/io/clickhouse/src/test/java/org/apache/beam/sdk/io/clickhouse/AtomicInsertTest.java:
##########
@@ -56,7 +56,7 @@ private static boolean shouldAttempt(int i, long count) {
/** With sufficient block size, ClickHouse will atomically insert all or
nothing. */
@Test
public void testAtomicInsert() throws SQLException {
- int size = 1000000;
+ int size = 100000;
Review Comment:
setting 1M cause insert error. it also works with 500K rows, but i have
changed it to 100K a deeper investigation need to be done here.
##########
sdks/java/io/clickhouse/src/test/java/org/apache/beam/sdk/io/clickhouse/AtomicInsertTest.java:
##########
@@ -92,9 +92,10 @@ public void testAtomicInsert() throws SQLException {
* With sufficient block size, ClickHouse will atomically insert all or
nothing. In the case of
* replicated tables, it will deduplicate blocks.
*/
+ // @Test
@Test
public void testIdempotentInsert() throws SQLException {
- int size = 1000000;
+ int size = 100000;
Review Comment:
setting 1M cause insert error. it also works with 500K rows, but i have
changed it to 100K a deeper investigation need to be done here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
