AdalbertMemSQL commented on code in PR #24290:
URL: https://github.com/apache/beam/pull/24290#discussion_r1049856241
##########
sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java:
##########
@@ -370,8 +386,6 @@ public DataSource getDataSource() {
abstract @Nullable RowMapper<T> getRowMapper();
- abstract @Nullable Coder<T> getCoder();
Review Comment:
Now they can do it using RowMapperWithCodder
https://github.com/apache/beam/pull/24290/files#diff-1ae81cb3e2f6d00213f38c6ebcee815cea50c993e9a4a0514b0d93f7837af0bcR237-R240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
