TheNeuralBit commented on a change in pull request #12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r453085135
##########
File path: sdks/java/io/expansion-service/build.gradle
##########
@@ -33,6 +33,9 @@ ext.summary = "Expansion service serving several Java IOs"
dependencies {
compile project(":sdks:java:expansion-service")
compile project(":sdks:java:io:kafka")
+ runtime project(":sdks:java:io:jdbc")
runtime library.java.kafka_clients
+ // Include postgres so it can be used with external JDBC
+ runtime library.java.postgres
Review comment:
They must be in the shadowJar though right? Otherwise the request to
expand jdbc:read would fail immediately
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
