piotr-szuberski edited a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-657410328
@chamikaramj @TheNeuralBit I've made the requested changes. Also, I found an utility in JdbcUtil that is able to call proper set method on PreparedStatement, so I think there is no need to test BeamRowPreparedStatementSetter separately anymore (there already is a test of this utility and it would be a copy-paste). I had to make the JdbcUtil class public instead of package-private because I wanted to have external classes in separate package. I'll publish the external builder test after this PR is merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
